Invalid template property or properties error

I passed your JSON through a JSON pretty print ( can you please post it to gist.github.com so it's easier to read? ) and it looks like your lambda resource is outside of the Resources block.

Edited by: cwprogram on Jul 22, 2017 5:21 PM

You're correct about the Lambda being outside of the resources block. CloudFormation's error message should indicate that.

I also had to remove two parameters which were not used (DomainName and CloudSearchDomain).

Now I get this error message:
Status of stack serverlessbook is UPDATE_ROLLBACK_COMPLETE. It seems to be failed.

Where do I look to see what caused the rollback?

In the CloudFormation console go to the listing of Stacks. From there either click on the name of the stack in question in the listing, or select it (by clicking on the check box) and then go to "Events". This will show what Resource failed and indicate why it failed.

{
"Parameters": {
"DeploymentBucket": {
"Type": "String",
"Description": "S3 bucket name where built artifacts are deployed"
},
"ProjectVersion": {
"Type": "String",
"Description": "Project Version"
},
"DeploymentTime": {
"Type": "String",
"Description": "It is a timestamp value which shows the deployment time. Used to rotate sources."
},
"DomainName": {
"Type": "String",
"Description": "Domain Name to serve the application"
},
"CloudSearchDomain": {
"Type": "String",
"Description": "Endpoint Name for CloudSearch domain"
}
},
"Resources": {
"LambdaExecutionRole": {
"Type": "AWS::IAM::Role",
"Properties": {
"Path": "/",
"AssumeRolePolicyDocument": {
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Principal": {
"Service": [
"lambda.amazonaws.com",
"apigateway.amazonaws.com"
]
},
"Action": [
"sts:AssumeRole"
]
}
]
},
"ManagedPolicyArns": [
"arn:aws:iam::aws:policy/service-role/AWSLambdaVPCAccessExecutionRole"
]
}
},
"LambdaCustomPolicy": {
"Type": "AWS::IAM::Policy",
"Properties": {
"PolicyName": "LambdaCustomPolicy",
"PolicyDocument": {
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"s3:ListBuckets"
],
"Resource": "*"
}
]
},
"Roles": [
{
"Ref": "LambdaExecutionRole"
}
]
}
},
"TestLambda": {
"Type": "AWS::Lambda::Function",
"Properties": {
"Handler": "com.serverlessbook.lambda.test.Handler",
"Runtime": "java8",
"Timeout": "300",
"MemorySize": "1024",
"Description": "Test lambda",
"Role": {
"Fn::GetAtt": [
"LambdaExecutionRole",
"Arn"
]
},
"Code": {
"S3Bucket": {
"Ref": "DeploymentBucket"
},
"S3Key": {
"Fn::Sub": "artifacts/lambda-test/${ProjectVersion}/${DeploymentTime}.jar"
}
}
}
}
}
}

fixed template. please accept the answer