Transit gateway & VPC peering - IP forwarding

A few observations:

• Transitive Routing: As VPC Peering doesn't support transitive routing, the path from the Citrix VPC to the Transit VPC over VPC Peering cannot be used to establish connectivity. Unfortunately you comment that "2. Direct VPN connectivity between branches and Citrix VPC would not be possible immediately" rules out one solution approach. Instead you might want to look into connecting the Citrix VPC to the TGW to have a path between Citrix VPC and branches.
• Overlapping CIDRs: You need to clarify what "Prod VPC and Data Center Subnets have overlapping CIDRs" means here. If a host in the Citrix VPC needs to talk to endpoints in the Prod VPC and Data Center Subnet under the same IP address, you'll need to look into NAT. If not, more specific routes might be sufficient.